[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patches] [PATCH] Powerpc/trampline: consider __NO_FPRS__

On Fri, 18 Jun 2010, Sebastian Andrzej Siewior wrote:

> * Joseph S. Myers | 2010-06-17 20:46:28 [+0000]:
> >I don't see any reason for this to be EGLIBC-specific; have you tried 
> >submitting it to libc-alpha?  
> No I haven't tried yet. I'm not really sure where this code is used.
> Giving the fact that we store here volatile registers here we might need
> to use evstdd and evldd on __SPE__. What do you think?

If you do need to do that, then that would definitely indicate a more 
complicated approach, possibly including creating a copy of the file for 
an appropriate ports directory (guessing that you'd want to save the 
64-bit GPRs once only so would need to change what's otherwise generic 
code to allow for that) - and the SPE support is in EGLIBC only.  But then 
you would also need to provide a proper rationale with your patch, 
explaining how this code is used and why the changes are needed.  Simply 
disabling code for floating-point registers when there are no FPRs, 
however, is something that can be considered obvious without needing such 
a detailed explanation.  An actual SPE version of this code would also 
likely involve large enough changes to need an FSF copyright assignment, 
whereas the disabling in the absence of FPRs is small enough not to need 
an assignment.

Joseph S. Myers