[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patches] menuconfig for EGLIBC
- To: Steve Longerbeam <steve_longerbeam@xxxxxxxxxx>
- Subject: Re: [Patches] menuconfig for EGLIBC
- From: "Joseph S. Myers" <joseph@xxxxxxxxxxxxxxxx>
- Date: Wed, 7 Dec 2011 23:46:50 +0000 (UTC)
On Wed, 7 Dec 2011, Steve Longerbeam wrote:
> On 12/05/2011 05:39 PM, Joseph S. Myers wrote:
> > Only a couple of comments on this patch:
> > In config-postproc.pl you call a subroutine with leading '&', but man
> > perlstyle advises "Call your subroutines as if they were functions or list
> > operators to avoid excessive ampersands and parentheses." - it's rarely
> > necessary to use the '&' in modern perl (as I recall, it was perl 4 that
> > required it).
> > It appears to be usual for makefiles to call perl scripts using $(PERL)
> > rather than directly.
> attached is the updated patch to address above issues.
Thanks. Today's revised patch versions are OK. Could you please provide
the ChangeLog entries (separately for each of the three patches) for
ChangeLog.eglibc in standard GNU ChangeLog entry style?
Joseph S. Myers
Patches mailing list