[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patches] [PATCH] Remove debug print outs from the run-time linker (RTLD_DEBUG option group)

Daniel Jacobowitz wrote:
On Mon, Feb 01, 2010 at 01:53:37AM +0300, Maxim Kuvyrkov wrote:

Would you please review the following patch which make EGLIBC's
run-time linker 8-10% smaller.

The following patch adds a new option group to EGLIBC --
OPTION_EGLIBC_RTLD_DEBUG.  This group makes debug print-outs of the
run-time linker optional.  These are the print-outs triggered by
LD_DEBUG and TRACE_PRELINKING environment variables.  Removing the
associated code makes the run-time linker smaller.

I believe that disabling LD_TRACE_PRELINKING will break the
prelinker.  Are those a big portion of the space savings?  If not, may
want to leave them alone.

Along the same lines, it's worth checking whether ldd still works.

When using the cross prelinker (cross rtld) patches, I don't think this will cause a problem. So it still looks beneficial to me. But I do believe it needs to be clearly listed (where ever appropriate) that this will likely break both prelinking on the target and ldd.